fix: add focus state to swaps input for improved accessibility #29252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-design-system
georgewrmarshall
changed the title
… keyboard and vision impaired users
georgewrmarshall
force-pushed
the
fix/accessibility-bug-swaps-input-focus
branch
from
61b2152 to
43eed26
Compare
| @@ -893,6 +893,7 @@ export default function PrepareSwapPage({ | |||
| display={DISPLAY.FLEX} | |||
| justifyContent={JustifyContent.spaceBetween} | |||
| alignItems={AlignItems.center} | |||
| gap={4} | |||
There was a problem hiding this comment.
Adds gap between asset selector and input
Comment on lines
-136
to
+139
| outline: none; | ||
| margin-right: -4px; | ||
|
|
||
| input { | ||
| padding-right: 0; | ||
| padding-right: 4px; |
There was a problem hiding this comment.
Negative margin allows for alignment and padding of number to remain the same while input is in focus state
Builds ready [43eed26]
Page Load Metrics (2047 ± 150 ms)
Bundle size diffs
|
georgewrmarshall
requested review from
DDDDDanica,
brianacnguyen and
NidhiKJha
|
Tested: |
DDDDDanica
approved these changes
Dec 17, 2024
jclancy93
approved these changes
Dec 17, 2024
metamaskbot
added
the
release-12.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current swaps input implementation hides the focus indicator, making it inaccessible for users with vision impairments and those relying on keyboard navigation. This creates barriers for:
This PR improves accessibility by:
These changes ensure compliance with WCAG 2.1 Success Criterion 2.4.7 (Focus Visible), which requires that keyboard focus indicators be visible and distinguishable.
Related issues
Fixes: #26662
Manual testing steps
Screenshots/Recordings
Before
Input field shows no focus indicator when navigating with keyboard
before.mov
After
Input field shows clear focus indicator when navigating with keyboard, with padding-right: 4px
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist